London | 25-SDC-Nov | Aida Eslamimoghadam | Sprint 5 | Prep exercises #298
Conversation
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
aydaeslami
changed the title
aydaeslami
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Very good work on these tasks, there are some areas where you could improve further
There was a problem hiding this comment.
You should not commit cache files like this, can you figure out how to remove them?
There was a problem hiding this comment.
DS Store files don't need to be commited either
There was a problem hiding this comment.
Have you considered also adding return types?
There was a problem hiding this comment.
is this meant to be a python file? is the name correct?
There was a problem hiding this comment.
Can you describe the difference and any dis/advantage of using a class method vs a function?
| def print_family_tree(person: Person) -> None: | ||
| print(person.name) | ||
| for child in person.children: | ||
| print(f"- {child.name} ({child.age})") |
There was a problem hiding this comment.
Can this print grandchildren recursively?
There was a problem hiding this comment.
You might want to add some data validation to the input allowing for reentry.
You might want to offer a prompt indicating the choices available for operating system.
If I type simply 'Ubuntu' as an OS it does not work, can you find out why?
LonMcGregor
added
Reviewed
2 participants
Self checklist
Changelist
This PR includes debugging the Sprint 5 exercises related to types, classes, objects, inheritance, and composition.